fix: `httpSubscriptionLink` deserialization by using output deserializer

trpc / trpc

🧙‍♀️ Move Fast and Break Nothing. End-to-end typesafe APIs made easy.

https://tRPC.io

MIT License

34.28k stars 1.21k forks source link

fix: `httpSubscriptionLink` deserialization by using output deserializer #5901

Closed Katli95 closed 1 month ago

Katli95 commented 1 month ago

Closes #5900

🎯 Changes

Change de-serializer from input to output:

https://github.com/trpc/trpc/blob/755f28799f40eb7fb56d065b6793af10271d407c/packages/client/src/links/httpSubscriptionLink.ts#L98

✅ Checklist

[x] I have followed the steps listed in the Contributing guide.
[x] If necessary, I have added documentation related to the changes made.
[x] I have added or updated the tests related to the changes made.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 16, 2024 7:15am

vercel[bot] commented 1 month ago

@Katli95 is attempting to deploy a commit to the trpc Team on Vercel.

A member of the Team first needs to authorize it.

Katli95 commented 1 month ago

Quick question, as I'm not familiar with the publishing schedule/processes, when might this become available via npm after merge?

Katli95 commented 1 month ago

My pleasure @KATT, @BeBoRE did most of the work finding what was wrong 😅 ~~but did you perhaps miss my question above?~~

~~Quick question, as I'm not familiar with the publishing schedule/processes, when might this become available via npm after merge?~~

Edit: Scratch that, it's live 😂😍 Dayumn, nice pipelines ✌️

github-actions[bot] commented 1 month ago

This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you.