search

trptcolin / reply

REPL-y: A fitter, happier, more productive REPL for Clojure.
Eclipse Public License 1.0
337 stars 44 forks source link

0.3.6 pom marks tools.nrepl dep as scope "test" #162

Closed alandipert closed 9 years ago

alandipert commented 9 years ago

Over at https://github.com/boot-clj/boot/pull/168 @bbatsov bumped our reply dependency to 0.3.6 but it broke our build. We got an error during AOT that tools.nrepl was missing.

We tracked the problem down to the fact that the reply pom as found on Clojars depends on tools.nrepl but with "test" scope. This prevents consumers of reply from downloading tools.nrepl as a transitive dependency.

We think this is probably caused by a lein bug, https://github.com/technomancy/leiningen/issues/1748. You might be able to fix it by deploying with a different version of lein.

Anyway, thanks in advance for looking into it! For anyone else with this problem, one workaround is to depend on [org.clojure/tools.nrepl "0.2.8"] in addition to [reply "0.3.6"].

trptcolin commented 9 years ago

Ah, yuck, thanks for the detective work! I went ahead and released [reply "0.3.7"] with @jcrossley3's workaround linked from technomancy/leiningen#1771

I guess I probably could've re-deployed 0.3.6 with an older version of lein, but figured I'd do a new one on the off-chance someone is relying on that [afaict wrong] behavior.

alandipert commented 9 years ago

:metal: :dolphin: :metal: