search

trptcolin / reply

REPL-y: A fitter, happier, more productive REPL for Clojure.
Eclipse Public License 1.0
337 stars 44 forks source link

Bump jline2 version. #174

Closed WillChilds-Klein closed 6 years ago

WillChilds-Klein commented 6 years ago

closes #173

I'm not sure what your acceptance standards beyond the lein do compile, spec in the repo's .travis.yml (which succeeded locally for me), but I was able to confirm that with this version bump, running the code locally with lein trampoline run yielded a REPL that honored my ~/.inputrc's custom vi keybindings.

WillChilds-Klein commented 6 years ago

looks like the TravisCI run failed (last successful run being almost 2 years ago). i've included some info below, am looking into the CI build failure now.

$ lein do deps, compile, spec

......................................

Finished in 21.69968 seconds
38 examples, 0 failures

$ java -version
java version "1.8.0_05"
Java(TM) SE Runtime Environment (build 1.8.0_05-b13)
Java HotSpot(TM) 64-Bit Server VM (build 25.5-b02, mixed mode)

$ lein -v
Leiningen 2.8.1 on Java 1.8.0_05 Java HotSpot(TM) 64-Bit Server VM
trptcolin commented 6 years ago

👍 thanks a bunch for both fixes!

WillChilds-Klein commented 6 years ago

no trouble! any chance we could roll this out into a 0.3.8 release on clojars for upstream consumers?

please let me know if/how i can help; i'm a total neophyte to the clojars/github release process...

WillChilds-Klein commented 6 years ago

@trptcolin -- any word on a 0.3.8 release for consumers?

trptcolin commented 6 years ago

I was hoping to roll in a version bump for sjacket as well (for https://github.com/cgrand/sjacket/pull/23) - if that doesn't get released in the next few days I can either deploy this alone or move to depend on my own separate clojars release of sjacket.

WillChilds-Klein commented 6 years ago

hi @trptcolin, it looks like cgrand/sjacket#23 is not being acted upon. can we roll out 0.3.8 on clojars/mvn central so that lein can pick up this change? happy to help with the release process if you like.

trptcolin commented 6 years ago

@WillChilds-Klein released in 0.3.8: https://clojars.org/reply