search

trptcolin / reply

REPL-y: A fitter, happier, more productive REPL for Clojure.
Eclipse Public License 1.0
337 stars 44 forks source link

Travis builds failing for openjdk6 and oraclejdk7 #196

Closed mrichards42 closed 3 years ago

mrichards42 commented 5 years ago

Builds are failing when trying to install these jvms: e.g. https://travis-ci.org/trptcolin/reply/jobs/489646637 and https://travis-ci.org/trptcolin/reply/jobs/489646639

According to travis docs it looks like these jvms are no longer installed by default.

bbatsov commented 5 years ago

Yeah. We should update the build matrix. Possible switch to Circle CI, given the news of Travis's demise.

trptcolin commented 5 years ago

Thanks, yep. I got the build green again, which should unblock PRs, but JDK6 is still missing for now so I'm leaving this open.

bbatsov commented 5 years ago

Do you think that running the build on JDK 6 and 7 is even needed at this point? According to the last Clojure survey it seems almost no one uses them. Probably focusing on Java 8, Java 11 and 12 (in general the supported LTS and short-cycle releases) is the best support strategy here.

trptcolin commented 5 years ago

My preference is always to maintain backwards compatibility / avoid breaking people. But if Leiningen's OK breaking support for JDK 6/7, then I'm OK with doing that in REPLy - as long as we bump major versions and make it really clear for users.

bbatsov commented 5 years ago

I share your sentiment in general, but I think that once we get to a point where almost no one is using something it becomes counter-productive to support it. I'm not sure what JDK Lein is targetting, but nREPL itself targets JDK 8 and so far no one was complained about this. Maybe it works on older JDKs (I'm reasonably certain it works on 7), but we're not making any efforts to ensure this.

bbatsov commented 4 years ago

@trptcolin I noticed that Travis build is broken and I decided to tackle the transition to CircleCI. I basically replicated the build used by Lein, so we're now testing on everything supported by Lein itself. I just need you to enable the builds, as I don't think I can do this myself.

trptcolin commented 4 years ago

Enabled! https://app.circleci.com/pipelines/github/trptcolin/reply

bbatsov commented 4 years ago

Thanks! 🙇

bbatsov commented 4 years ago

There's some weird failure as the OpenJDK has unexpected version format (there's a + there), but overall we're in business.