search

trptcolin / reply

REPL-y: A fitter, happier, more productive REPL for Clojure.
Eclipse Public License 1.0
338 stars 44 forks source link

[Fix #150] Replace clojure-complete with incomplete #203

Closed bbatsov closed 3 years ago

bbatsov commented 3 years ago

The spiritual successor of https://github.com/trptcolin/reply/pull/153

bbatsov commented 3 years ago

@trptcolin incomplete is almost a drop in replacement for clojure-complete, which significantly reduced the scope of the changes. Funny enough the build passed from the first try. 😆 If you like the change I'd appreciate a new release, so I can swap the version of REPL-y in Leiningen.

trptcolin commented 3 years ago

Nice! My only question was about backwards compatibility (since this code runs in the end user's project runtime) and whether we're introducing a requirement for the clojure 1.10.1 that incomplete has in its project.clj.

I do know that's not the case today (I pulled incomplete down and ran its test suite under Clojure 1.7 after a few tweaks to its project.clj), but I imagine that might change in the future? At any rate, something to keep in mind as incomplete gets updated.

bbatsov commented 3 years ago

It actually targets Clojure 1.7, same as nREPL. It might even run on older versions of Clojure, as the code is pretty simple and doesn't use any "modern" features. I put together the project file and test matrix in a hurry, I guess I'll have to update them.

trptcolin commented 3 years ago

👍 0.5.0 is released - thanks!