trquinn / changa

Clone of UIUC public ChaNGa
1 stars 2 forks source link

Build system fixes #3

Closed insaneinside closed 10 years ago

insaneinside commented 10 years ago

These are some simple changes meant to enable better use of the build system.

I'm not 100% sure I wrote the out-of-source pattern rules in Makefile.in (l. 144-155) correctly, so let me know what needs changing and I'll take care of it.

trquinn commented 10 years ago

I tried this on "stampede" and ran into the following error: ../../charm/bin/charmc -O3 -DINTERLIST_VER=2 -DHEXADECAPOLE -DCOOLING_NONE -DREDUCTION_HELPER -DMERGE_REMOTE_REQUESTS -DCHANGESOFT -g -O2 -I.. -c -o dumpframe.o ../dumpframe.c ../dumpframe.c:11:20: error: config.h: No such file or directory

I think you need to add a "-I$SOURCE_DIR" to the CFLAGS define similar to what you added to the CXXFLAGS define in Makefile.in.

insaneinside commented 10 years ago

You didn't have any problems with the generated Makefile.dep listing "liveViz.h" (i.e. with no path in front of it) as a dependency for any object built from a source that includes ParallelGravity.h? Trying a clean build just now I had to change #include "liveViz.h" to #include <liveViz.h> to avoid that. (Apparently the Charm dependency-generation code doesn't actually do a search for quoted includes or something.)

insaneinside commented 10 years ago

Fixed both of those issues with these two most recent commits, in any case.