search

trs-80 / WWW-Spotify

Perl wrapper for Spotify Web API
Other
5 stars 3 forks source link

Error handling #15

Closed trs-80 closed 2 years ago

trs-80 commented 2 years ago

While checking on a failed test I noticed this:

Theset-outputcommand is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Should we need to create and issue to track this?

oalders commented 2 years ago

Should we need to create and issue to track this?

I think this may get fixed automatically once https://github.com/shogo82148/actions-setup-perl/pull/1288/files is merged.

trs-80 commented 2 years ago

@oalders I am not up to date on the next step here, if this is merged will it also release to CPAN or is there another step required after the merge? That being said, based on the changes made are you OK with this being merged?

oalders commented 2 years ago

if this is merged will it also release to CPAN or is there another step required after the merge

The release is done manually via Dist::Zilla. If you're familiar with it (or would like to learn), you could handle that part or you can ask me to do it.

That being said, based on the changes made are you OK with this being merged

I'll take another quick pass. At the end of the day, I'll defer to your judgement, though, as this is your module. 😄