search

trs-80 / WWW-Spotify

Perl wrapper for Spotify Web API
Other
5 stars 3 forks source link

fix credentials #8

Closed trs-80 closed 4 years ago

trs-80 commented 4 years ago

Increasing flexibility in sending oauth credentials

oalders commented 4 years ago

I can push a fix for the failing Pod coverage tests. There are some uncovered methods, but we could allow that for now.

If you want a smaller diff, you don't need to include any boilerplate changes made by Dist::Zilla in the PR, since those just get created and committed when the dist gets released.

trs-80 commented 4 years ago

I am fine with excluding the boilerplate changes - anything you could do to shepherd this through would be greatly appreciated.

On Mon, Sep 14, 2020 at 8:59 AM Olaf Alders notifications@github.com wrote:

I can push a fix for the failing Pod coverage tests. There are some uncovered methods, but we could allow that for now.

If you want a smaller diff, you don't need to include any boilerplate changes made by Dist::Zilla in the PR, since those just get created and committed when the dist gets released.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/trs-80/WWW-Spotify/pull/8#issuecomment-692035093, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA2WDVHDL7YRI5TQVBBXQTSFYHSVANCNFSM4RLRCP4A .

oalders commented 4 years ago

I've moved your changes into #10, but there's still a failing test that was introduced by the changes. Would you be able to have a look at it?

oalders commented 4 years ago

Sorry -- I should have force-pushed to a different branch. Having said that, this is ready for merge so I'll do that and release.