trubrics / streamlit-feedback

Collect user feedback from within your Streamlit app
MIT License
128 stars 13 forks source link

Feedback is not getting cleared. Only 1st feedback getting saved #22

Open himsgpt opened 7 months ago

himsgpt commented 7 months ago

After user gives a feedback based on a response. The feedback doesn't get cleared for another feedback on another response. ANy help?

import streamlit as st
from streamlit import session_state as ss
from streamlit_feedback import streamlit_feedback

if 'qr' not in ss:
    ss.qr = None

def ai_response(query):
    ss.qr = "Hey, what's up?" 

with st.form("query_form_k", clear_on_submit=False):
    query = st.text_area("Enter your query")
    st.form_submit_button('Get response', on_click=ai_response, args=(query,))

with st.container():
    st.write('Ai Response:')

    if ss.qr is not None:
        st.write(ss.qr)

with st.container():
    st.write('Your feedback:')

    feedback = streamlit_feedback(
        feedback_type="thumbs",
        optional_text_label="[Optional] Please provide an explanation",
        align="flex-start",
        args=(query),
        key='c1'
    )

    if ss.qr is not None and feedback:
        st.write(feedback)

image

lvwyk commented 7 months ago

I'm having the same issue :(

jeffkayne commented 7 months ago

To collect multiple feedback points with the same component, you can set a dynamic key. See the example below:

import streamlit as st
from streamlit_feedback import streamlit_feedback

def handle_feedback(user_response):
    st.toast("✔️ Feedback received!")

if "feedback" not in st.session_state:
    st.session_state.feedback = []

if "feedback_key" not in st.session_state:
    st.session_state.feedback_key = 0

if st.button("Refresh feedback component"):
    st.session_state.feedback_key += 1  # overwrite feedback component

result = streamlit_feedback(
    feedback_type="thumbs",
    align="flex-start",
    on_submit=handle_feedback,
    key=f"feedback_{st.session_state.feedback_key}",
)

if result:
    st.session_state.feedback.append(result)

st.session_state.feedback
himsgpt commented 7 months ago

Thanks. I slightly modified this to fit my case. On submitting ‘Get_response’ i run reset_cb. This works fine except 1 last bug.

on submitting the feedback, since the app reruns. The ai_response get’s cleared, Any solution to keep the content as is in the form on submitting the feedback? Since the ai_response function is expensive, i don’t want to rerun it on submitting feedback.


import streamlit as st
from streamlit import session_state as ss
from streamlit_feedback import streamlit_feedback
import uuid

if 'fbk' not in ss:
    ss.fbk = str(uuid.uuid4())

def reset_cb():
    """Reset callback for feedback, etc.

    This can be used to save interactions.
    """
    ss.fbk = str(uuid.uuid4())  # use new key to display new feedback prompt

def ai_response():
    """Gets query text and use it to build a response.

    It assigns its response to the query response.
    """
    res = "Hey, what's up?"
    ss.qr = f"My response is: {res}"
    st.write(ss.qr)

# Build a form to receive user query input.
with st.form("query_form_k", clear_on_submit=False):
    st.text_area("Enter your query", key='qt')
    check = st.form_submit_button('Get response', on_click=reset_cb)
    if check:
        st.write('Ai Response:')
        ai_response()

# Manage the feedback.
with st.container():
    st.write('Your feedback:')

    streamlit_feedback(
        feedback_type="thumbs",
        optional_text_label="[Optional] Please provide an explanation",
        align="flex-start",
        key=ss.fbk
    )
aymbot commented 5 months ago

I am running into the same issue, and currently its only either or for me, so if anyone has a tip or so, would love to hear it.