search

true3dco / splashgen

Rapidly build landing pages in <20 lines of python
https://splashgen.sh
MIT License
252 stars 16 forks source link

Error integrating with github pages #3

Closed Dohva closed 3 years ago

Dohva commented 3 years ago

I've run into an issue with github pages, where it fails to serve the default logo. The path in src successfully points to the image when followed explicitly in another tab, but loads as an empty box on the site. When built locally it also successfully serves the image.

Link to live page Partial screenshot attached image

traviskaufman commented 3 years ago

Thanks so much for reporting! I believe this was fixed in https://github.com/true3dco/splashgen/commit/c24e2bc21a05904ccc230105bbbb8c761c17c65f

Which version of splashgen do you have installed (pip show splashgen | grep Version)? If it's < 0.0.26, I believe you can fix this issue by running pip install -U splashgen to upgrade. Let me know if that doesn't work!

Dohva commented 3 years ago

I was using version 0.0.24, and upgrading to the newest version fixed the issue. Thank you for replying.

traviskaufman commented 3 years ago

Excellent! My pleasure 👍🏻

Btw, the repo looks really interesting. If you wind up writing something about how you are able to use GH actions to publish to GH pages without checking in the build folder, we'd love to include that info in our README.

Dohva commented 3 years ago

It actually turned out to be really simple, once I got the hang of GitHub Actions. Just plug the workflow under the 'actions' branch into a repo, and it'll build in the cloud and push the build/ folder to the specified branch. Feel free to integrate anything from the repo into your readme. I'm happy to do a quick rundown of the process.