Template key is not reliable

[ysegorov]

Just a note on template key generation.

Considering this strange code

var s = 1,
    a = t7`<ul>${s}</ul>`,
    b = t7`<ol>${s}</ol>;
console.log(a, b);

we will have the following in console

Object { tag: "ul", attrs: Object, children: "1" } Object { tag: "ul", attrs: Object, children: "1" }

As for the library - excellent idea, Dominic! :)

[trueadm]

Thanks for trying t7 out and thank you for finding that bug. :)

[ghost]

@trueadm Why don't you just use template.join() for the cache key?

[trueadm]

@joelrich Large strings for cache key results in slower lookup times than hashed results.

[ghost]

Have you verified that? I am asking because such property access of is very likely implemented as a hashtable (which does basically the same, just implemented in C).

[trueadm]

In C, you have a limit on hashtables in terms of the key. Same applies here, especially with very large strings. Also, you should avoid using string.join() if you can avoid it as it's quite slow in all browsers.