search

trueadm / t7

Lightweight virtual DOM templating library
900 stars 31 forks source link

Example from readme.md does not work #3

Closed maximecaron closed 9 years ago

maximecaron commented 9 years ago

To render correctly in cito.js it should look like this:

{"tag":"div","attrs":{"class":"foo"},"children":[{"tag":"h1","attrs":{},"children":["Hello ","World"]},{"tag":"ul","attrs":{"id":"bar"},"children":[{"tag":"li","attrs":{"class":"item"},"children":[{"tag":"span","attrs":{},"children":["The item is: ","Ball"]}]},{"tag":"li","attrs":{"class":"item"},"children":[{"tag":"span","attrs":{},"children":["The item is: ","Boat"]}]}]}]}

but currently returning this instead:

{"tag":"div","attrs":{"class":"foo"},"children":[{"tag":"h1","attrs":{},"children":["Hello ","World"]},{"tag":"ul","attrs":{"id":"bar"},"children":[[{"tag":"li","attrs":{"class":"item"},"children":[{"tag":"span","attrs":{},"children":["The item is: ","Ball"]}]},{"tag":"li","attrs":{"class":"item"},"children":[{"tag":"span","attrs":{},"children":["The item is: ","Boat"]}]}]]}]}

trueadm commented 9 years ago

Hi @maximecaron, this has now been fixed in the latest commit :) thank you for reporting it.

maximecaron commented 9 years ago

Hi Dominic, Thanks a lot for the quick fix. I was wondering if you could add instruction on how to run the precompiler. I wanted to try it but it was not clear to me how to use it.

Cheer! Maxime Caron

On Thu, Jul 9, 2015 at 1:43 AM, Dominic Gannaway notifications@github.com wrote:

Hi maximecaron, this has now been fixed in the latest commit :) thank you for reporting it.

— Reply to this email directly or view it on GitHub https://github.com/trueadm/t7/issues/3#issuecomment-119876846.

trueadm commented 9 years ago

Ah, I wasn't meant to merge that version of the compiler as there was a big bug found in the precompiler that I need to fix before it's usable again (broke several refactors ago). I'm probably going to branch that precompiler off into a separate repo at some stage as I feel it's a beast in its own right. I'll be sure to let you know once it's available again to play with :)

maximecaron commented 9 years ago

Ok perfect, Thanks.

On Fri, Jul 10, 2015 at 11:35 AM, Dominic Gannaway <notifications@github.com

wrote:

Ah, I wasn't meant to merge that version of the compiler as there was a big bug found in the precompiler that I need to fix before it's usable again (broke several refactors ago). I'm probably going to branch that precompiler off into a separate repo at some stage as I feel it's a beast in its own right. I'll be sure to let you know once it's available again to play with :)

— Reply to this email directly or view it on GitHub https://github.com/trueadm/t7/issues/3#issuecomment-120489716.