search

trueagi-io / hyperon-experimental

MeTTa programming language implementation
https://metta-lang.dev
MIT License
123 stars 43 forks source link

Enable MacOSX Apple Silicon release #680

Closed vsbogd closed 2 months ago

vsbogd commented 2 months ago

Fix deprecation warnings from release job, opt out musllinux by default in pyproject.toml, fix issue with insufficient permissions when building using macos-14 GitHub runner.

To install Python package for MacOSX Apple Silicon from test PyPi:

python3 -m pip install --index-url https://test.pypi.org/simple/ hyperon

Version 0.1.8.1 should be installed.

vsbogd commented 2 months ago

@Necr0x0Der already tried to install it on M1 so I am merging it.

luketpeterson commented 2 months ago

One thing that's worth mentioning. My changes moved the C lib tests from testing the static lib to testing the dynamic hyperonc lib. Meaning I switched the BUILD_SHARED_LIBS argument to ON in the install-hyperonc script. But that has no bearing on this change.

vsbogd commented 2 months ago

Meaning I switched the BUILD_SHARED_LIBS argument to ON in the install-hyperonc script. But that has no bearing on this change.

Actually it means we completely don't support musllinux platform, so the comment in https://github.com/trueagi-io/hyperon-experimental/blob/14bf9ee36467ee391f5b96d4bd61b3bda1e47af7/python/pyproject.toml#L39-L40 should be changed. @luketpeterson do you mind doing it in your branch then?

luketpeterson commented 2 months ago

Do you think I should go back to testing the static lib? My reason for switching the tests to the dynamic lib was a thought that the C users are likely to use the dynamic lib so it provides a cleaner test (closer to the user's config) and I figured it didn't harm anything because I thought we didn't support musl linux anyway.

But if there is a reason we might want to keep musl linux in the future, I can put the tests back to testing the static lib.

Otherwise I will do as you say and remove the comment entirely.

luketpeterson commented 2 months ago

@vsbogd (See above) just so Github notifies you about the comment in this closed issue.

vsbogd commented 2 months ago

But if there is a reason we might want to keep musl linux in the future, I can put the tests back to testing the static lib.

I don't think supporting musl is critical, thus I am ok switching to the using of dynamic libraries in tests. Anyway if something will change we can return to this question. The only thing which bothers me is to have clear clue in comments to understand what exactly is not supported on the musl platform.