search

truebit / xUnique

merge Xcode project file is so easy
https://fclef.wordpress.com
Other
1.5k stars 117 forks source link

add python3 compatibility #28

Closed heni closed 8 years ago

k06a commented 8 years ago

@truebit hope you have time to review this PR :)

truebit commented 8 years ago

Hi, @heni Thanks for the PR. It's good to add python3 compatability. But IMO, the targeting user (a.k.a iOS developers ) may not be familiar with Python. I do not think that involving a third party package six in the installation process is a good idea。 Could you add python3 compability without 3rd party packages？

heni commented 8 years ago

Ok, I have written all necessary methods from six explicitely

riveryan commented 8 years ago

Traceback (most recent call last): File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/runpy.py", line 170, in _run_module_as_main "main", mod_spec) File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/runpy.py", line 85, in _run_code exec(code, run_globals) File "/usr/local/lib/python3.5/site-packages/xUnique.py", line 527, in main() File "/usr/local/lib/python3.5/site-packages/xUnique.py", line 504, in main xcode_proj_path = args[0].decode(sys_get_fs_encoding()) AttributeError: 'str' object has no attribute 'decode'

I got this error with python3.

truebit commented 8 years ago

@riveryan What the command arguments did you use? And please remind, you should try master branch to use python3, instead of the pip version

truebit commented 8 years ago

@riveryan I just uploaded new pip version to pypi including this pr. You can update xunique using command: pip install -U xunique