search

truechain / truechain-consensus-core

TrueChain Consensus Protocol: Minerva
Apache License 2.0
161 stars 70 forks source link

update .proto rpc calls / data structures in line with engg codebase #36

Open arcolife opened 6 years ago

arcolife commented 6 years ago

in line with HybridConsensusHelp.proto from truechain-engineering-code

ref: https://github.com/truechain/truechain-engineering-code/blob/master/eth/truechain/HybridConsensusHelp.proto

iceming123 commented 6 years ago

Is it about the RLP encoding the data structure in proto error?

arcolife commented 6 years ago

@iceming123 tangentially related. One can either use RLPs or protobufs. https://github.com/prysmaticlabs/prysm/issues/150

go-ethereum codebase that you're integrating with mainnet would normally include RLP to talk to each other. but fastchain communicates with snailchain using protobuf.

but this issue right here is about making sure the .proto file we discussed, works for both. currently, it is facilitated to work for core-consensus itself, because of lacking simulations.