search

truechain / truechain-consensus-core

TrueChain Consensus Protocol: Minerva
Apache License 2.0
161 stars 70 forks source link

gvt restore issue in hmake build (rebuilds entire dep on change in vendor/manifest) #39

Closed arcolife closed 6 years ago

arcolife commented 6 years ago

either sort this in gvt restore or shift to go dep.

ref: https://gitter.im/truechain-net/engg-foss-global?at=5b45b9413d8f71623d6e9357

hixichen commented 6 years ago

Fixed manully but reorg the manifest. https://github.com/truechain/truechain-consensus-core/pull/63

arcolife commented 6 years ago

@hixichen this issue is about "rebuilding entire deps structure" if just a couple changes are seen in vendor manifest. It's about not having to build the entire dep chain, if possible. I don't think it should be closed?

gvt restore still functions the same way, doesn't it ?

hixichen commented 6 years ago

Not sure I fully understand your question. For dep management, you only need to restore them for the first time when you git clone the project.

It is developer's job to maintain the manifest file.

why do we need to rebuild the entire deps structure?

arcolife commented 6 years ago

@hixichen here's the thing - we do it first time. Then we git pull in some changes after some time. So the vendor manifest changes.

So the next time we build with hmake, it rebuilds deps, because it watches over manifest. This build, triggers gvt restore.