Brackets added to CloudFlare Zone ID in `external-dns` chart

HexPandaa commented 10 months ago

App Name

external-dns

Operating System

TrueNAS SCALE 23.10.1

App Version

0.13.6

Application Events

None

Application Logs

2023-11-09T14:36:48.779432139+01:00 time="2023-11-09T14:36:48+01:00" level=info msg="Instantiating new Kubernetes client"
2023-11-09T14:36:48.779442158+01:00 time="2023-11-09T14:36:48+01:00" level=info msg="Using inCluster-config based on serviceaccount-token"
2023-11-09T14:36:48.779636214+01:00 time="2023-11-09T14:36:48+01:00" level=info msg="Created Kubernetes client https://172.17.0.1:443"
2023-11-09T14:36:49.755122256+01:00 time="2023-11-09T14:36:49+01:00" level=error msg="zone [523f6c[...]d00e1] lookup failed, Could not route to /zones/[523f6c<REDACTED>d00e1], perhaps your object identifier is invalid? (7003), No route for that URI (7000)"
2023-11-09T14:36:49.755150509+01:00 time="2023-11-09T14:36:49+01:00" level=fatal msg="Could not route to /zones/[523f6c<REDACTED>d00e1], perhaps your object identifier is invalid? (7003), No route for that URI (7000)"

Application Configuration

Default CloudFlare configuration from the tutorial: only CloudFlare API Token configured. I then added my Zone ID in the relevant section

Describe the bug

The chart add brackets to the CF Zone ID, the URL accessed by the tool is /zones/[523f6c<REDACTED>d00e1] when it should be /zones/523f6c<REDACTED>d00e1.

To Reproduce

Instanciate a new external-dnsapp.
Add your CF API Token
Get your Zone ID from your CF dashboard and add it to the chart
Notice the mentioned error in the app logs
Edit the app and remove the zone ID
Notice the app now works as intended

Expected Behavior

The Zone ID should be passed without brackets, possibly calling the underling app flag multiple times if it is supported. Removing the Zone ID lets the app start normally, the app logs shows the zone ID passed during configuration is valid.

Screenshots

None

Additional Context

None

I've read and agree with the following

[X] I've checked all open and closed issues and my issue is not there.

PrivatePuffin commented 10 months ago

We pass it as an env-var like normal without adding or changing anything. So likely an upstream issue...

PrivatePuffin commented 10 months ago

Just to be clear: I did verify this in-code.

stavros-k commented 10 months ago

I assume this is about zone filter, which indeed is wrong. We pass it a string but it’s a list

stavros-k commented 10 months ago

If the configuration was provided would be more clear tho

PrivatePuffin commented 10 months ago

If the configuration was provided would be more clear tho

Shoot I misread was focussing on CF variables.

truecharts-admin commented 10 months ago

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists

truecharts / charts