truecharts / charts

Community Helm Chart Repository
https://truecharts.org
GNU Affero General Public License v3.0
1.12k stars 617 forks source link

[Syncthing] UMASK is not applied correctly #18917

Closed avanc closed 6 months ago

avanc commented 6 months ago

App Name

synthing

Operating System

TrueNAS SCALE 23.10.1

App Version

1.27.3

Application Events

![image](https://github.com/truecharts/charts/assets/2905029/9ed293c8-6462-4d24-a6ae-64ca5b7b1a37)

Application Logs

Nothing related found 
![image](https://github.com/truecharts/charts/assets/2905029/934a90f6-68c7-4a07-97d9-662391452508)

Application Configuration

image

Describe the bug

I changed UMASK to 0007 within the configuration.

To Reproduce

Install syncthing with UMASK=0007 Configure syncthing in web interface and sync one file.

Expected Behavior

Uploaded file has permission u=rw, g=rw, o=

Screenshots

UMASK within the container: image

File Permissions: image

Additional Context

Syncthing storage is mounted from mainpool.

I've read and agree with the following

PrivatePuffin commented 6 months ago

UMASK, just like PGID and PUID, is not an universal standard. It's added as a best-effort, following how the most containers handle it (set the env var and the container applies it during run-time).

However, we cannot give guarantees on it. It completely depends on the container creator.

avanc commented 6 months ago

@Ornias1993 Thanks for then quick response. Yes, the environment variable is set correctly. I saw that they just added that functionality upstream: https://github.com/syncthing/syncthing/commit/c4dfb66d8476d85124242d5d4d7c799567258278 So I have just to wait for 1.27.4.

Is the chart update done automatically, or is this a manual thing (i.e. shall I create a PR to bump to 1.27.4)?

alfi0812 commented 6 months ago

Upstream updates get added automatically. But can take a bit.

avanc commented 5 months ago

Short information that the latest version now includes the fix and everything is working as expected.

I love OSS!

PrivatePuffin commented 5 months ago

@avanc I would like to request that you don't keep responding on issues that are closed.

Once an issue of closed because it's an upstream issue, its literally zero concern of ours, but responses do take staff time to read and push notifications to people that have better things to do.

If you want to discuss how updates are processed or something else that is not related to an issue, please use the discord like normal. Our github is purely for code-related issues.