search

truecharts / charts

Community Helm Chart Repository
https://truecharts.org
GNU Affero General Public License v3.0
1.13k stars 623 forks source link

[immich] Extra environment variables do not take effect for immich #20028

Closed goomadao closed 5 months ago

goomadao commented 5 months ago

Is your feature request related to a problem?

In China mainland, huggingface.co is blocked, so it's impossible to download the clip model and the recognition model in the immich-meachine-learning pod. In order to access the model, a mirror can be specified such as the hf-mirror.com. However, the environment variables which are set in the APPs GUI do not take effect for the immich app. For other apps such as jellyfin, it works fine.

Describe the solution you'd like

Make the extra environment variables valid in the pod for immich.

Describe alternatives you've considered

Or could you please add an HF_ENDPOINT field or something to specify the mirror for huggingface.co?

Additional context

No response

I've read and agree with the following

PrivatePuffin commented 5 months ago

extra env-vars work fine for the container they are put on. This is 100% covered with unittest.

However, we explicitly do not support china related issues. As we cannot guarantee that anything would work behind the great firewall.

I suggest replacing your government.

j1mbl3s commented 3 months ago

@Ornias1993 I am facing a similar issue regarding environment variables, but it has nothing to do with global politics.

My environment has a self-signed root CA and an intermediary ACME CA server. Additionally, it has a OIDC provider that gets its TLS certificate from the ACME server. Immich can be configured to use an OIDC provider, but it must make (HTTPS) requests to the provider.

Node.js ships with a trusted CA certificate bundle. It is recommended to add an additional CA certificate bundle using the NODE_EXTRA_CA_CERTS environment variable. However, it is currently not possible for the TrueCharts Immich app on TrueNAS SCALE because of this issue.

I've checked the Kubernetes resources (deploy, configmap, pod) and I do not see my extra environment variable anywhere, nor is it listed when I execute /bin/sh -c env on any of the running pods.

Could this issue be reconsidered?

PrivatePuffin commented 3 months ago

@Ornias1993 I am facing a similar issue regarding environment variables, but it has nothing to do with global politics.

My environment has a self-signed root CA and an intermediary ACME CA server. Additionally, it has a OIDC provider that gets its TLS certificate from the ACME server. Immich can be configured to use an OIDC provider, but it must make (HTTPS) requests to the provider.

Node.js ships with a trusted CA certificate bundle. It is recommended to add an additional CA certificate bundle using the NODE_EXTRA_CA_CERTS environment variable. However, it is currently not possible for the TrueCharts Immich app on TrueNAS SCALE because of this issue.

I've checked the Kubernetes resources (deploy, configmap, pod) and I do not see my extra environment variable anywhere, nor is it listed when I execute /bin/sh -c env on any of the running pods.

Could this issue be reconsidered?

This is so far out of our support scope, that i'm not going to comment on it.

PrivatePuffin commented 3 months ago

Could this issue be reconsidered?

Issue of OP is with him being in China, we explicitly do not support China. If you have any issues that are within support scope feel free to ask for support or filing a bugreport.