search

truecharts / charts

Community Helm Chart Repository
https://truecharts.org
GNU Affero General Public License v3.0
1.13k stars 622 forks source link

Latest Traefik release made changes to (potentially) the wrong middleware #3208

Closed uranderu closed 2 years ago

uranderu commented 2 years ago

App Name

Traefik

SCALE Version

22.02.1

App Version

2.8.1_12.0.22

Application Events

2022-07-18 18:52:06
Applied LoadBalancer DaemonSet ix-achilles/svclb-achilles-traefik-tcp
2022-07-18 18:52:06
Applied LoadBalancer DaemonSet ix-achilles/svclb-achilles-traefik
2022-07-18 19:03:03
Started container achilles-traefik
2022-07-18 19:03:03
Created container achilles-traefik
2022-07-18 19:03:02
Container image "tccr.io/truecharts/traefik:v2.8.1@sha256:808661df0066e25faf5d776e6d787d6771d093ca4a485bdb05bd359559a5e1a9" already present on machine
2022-07-18 19:03:02
Started container prepare
2022-07-18 19:03:01
Created container prepare
2022-07-18 19:03:01
Container image "ghcr.io/truecharts/multi-init:v0.0.1@sha256:41185dcea1e6f6a035d8090da40aecc6a69cef66b91dc1332a90c9d22861d367" already present on machine
2022-07-18 19:03:01
Add eth0 [172.16.9.78/16] from ix-net
Successfully assigned ix-achilles/achilles-traefik-765776d8db-xxgtf to ix-truenas
2022-07-18 19:03:00
Created pod: achilles-traefik-765776d8db-xxgtf
2022-07-18 18:52:06
Scaled up replica set achilles-traefik-765776d8db to 1
2022-07-18 19:02:49
Stopping container achilles-traefik
2022-07-18 19:02:49
Deleted pod: achilles-traefik-765776d8db-58pn7

Application Logs

2022-07-18 17:03:03.521238+00:00time="2022-07-18T19:03:03+02:00" level=info msg="Configuration loaded from flags."

Application Configuration

Didn't change anything aside from name

Describe the bug

In #3176 I requested a change to a middleware. It seems now that the change was made to the wrong middleware as I'm still seeing this response header in my middleware. The change was requested for the "default-basic-secure-headers@kubernetescrd" middleware. Which is defined in "basic-middleware.yaml", however the response header was instead removed from "tc-headers.yaml". I do not know what "tc" stands for so the change may be appropriate there as well, but for my usecase it isn't.

To Reproduce

  1. Install the latest version of Traefik. (2.8.1_12.0.22)
  2. Go to your Traefik dashboard and click on HTTP in the navbar.
  3. On the child navbar click on "HTTP Middlewares"
  4. Click on "default-basic-secure-headers@kubernetescrd"
  5. Observe the response header still being there

You can also go to any of the "tc" middlewares and see that the header is removed there.

Expected Behavior

I expect the header to be removed on the default basic middleware

Screenshots

.

Additional Context

EDIT: I've created a fix for this in PR #3211

I've read and agree with the following

truecharts-admin commented 1 year ago

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists