search

truecharts / charts

Community Helm Chart Repository
https://truecharts.org
GNU Affero General Public License v3.0
1.13k stars 622 forks source link

Add Option for LittleLinks Custom #4117

Closed sveken closed 1 year ago

sveken commented 1 year ago

Is your feature request related to a problem?

LittleLinks Custom is a more feature packed and updated version of Little Links which is offered currently in the charts. It offers features such as a Visual HTML Editor. Custom Theme support, Button editor with custom fonts. Animations, Custom link options, Social Share preview for individual users, plus some other added features over the base Littlelinks.

More Info is at https://github.com/JulianPrieber/littlelink-custom or https://littlelink-custom.com/

Describe the solution you'd like

Possibly an option to choose what version of little links to use? or investigating swapping the container?

Describe alternatives you've considered

This could be deployed via a custom docker image by the individual instead. or Accept that it isn't that important.

Additional context

No response

I've read and agree with the following

sveken commented 1 year ago

Dupe of #4099 Please actually search first before posting.

Thanks for your quick Response,

I posted the linked Dupe and the response was "Please file an enhancement request to change the container." Which i have done here. Is this the incorrect place?

thanks

xstar97 commented 1 year ago

I posted the linked Dupe and the response was "Please file an enhancement request to change the container." Which i have done here. Is this the incorrect place?

thanks

Not a dupe didn't see enhancement tag.

Honestly it should be it's own image as there would be very confusing for end users thinking it's the base variant vs the custom one.

Even if we revert the container we would have to modify the charts code to support it.

So we can't have an option to select between the two. Just isn't doable or maintainable.

PrivatePuffin commented 1 year ago

@Xstar97 image changes are also enhamcements. I veto having multiple apps for different flairs of the same application.

xstar97 commented 1 year ago

@Xstar97 image changes are also enhamcements. I veto having multiple apps for different flairs of the same application.

I'm all for it to make the pr myself and change it to the custom one. I'll do it later tonight.

PrivatePuffin commented 1 year ago

We have to take into account that LittleLink should stay stateless (aka: without storage). I don't think that this will be the case with this other image though....

PrivatePuffin commented 1 year ago

Feel free to investigate and close if this other image cannot be ran stateless @Xstar97

xstar97 commented 1 year ago

@Ornias1993 from my research on this back in October and rechecking now.... it is not stateless... it offers a lot of features compared to the original original but it will need storage for it to work.

Creating a new app entirely I'm assuming is also will not be recommended.

truecharts-admin commented 1 year ago

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists