truecharts / library-charts

Helm Library Charts for TrueCharts
Other
29 stars 36 forks source link

chore(volsync): increase test coverage for specific usecases #819

Closed PrivatePuffin closed 3 months ago

PrivatePuffin commented 3 months ago

Description Primarily aims to expand coverage for stageclassname and volumesnapshotclassname

⚒️ Fixes #

⚙️ Type of change

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

➕ App addition

If this PR is an app addition please make sure you have done the following.


Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance.

PrivatePuffin commented 3 months ago

I'm not 100% happy with this code/fix, but this should fix the issue of having to redundantly define storageClassName and fix the current rendering issues.

Which is kinda high prio, because it blocks using VolSync with a non-default storageClass atm