search

truecharts / public

Community Helm Chart Repository
https://truecharts.org
GNU Affero General Public License v3.0
1.14k stars 617 forks source link

[cloudflareddns] add Secret Support #10874

Closed hofq closed 1 year ago

hofq commented 1 year ago

Is your feature request related to a problem?

cloudflareddns does not support to select a pre existent secret for the API Key/ Token. Since i Maintain my Kubernetes using ArgoCD, i don't want clear text Passwords in my Git Inventory

Describe the solution you'd like

I want to be able to select a pre existent secret with selection options for the api key/ token

Describe alternatives you've considered

Using an alternative to the Helm Chart from truecharts, but there is none, so forking it.

Additional context

No response

I've read and agree with the following

stavros-k commented 1 year ago

You can already do that with Helm. https://truecharts.org/manual/helm/common/container/env

Define the env directly on the container and dont define it on the values.yaml

You most likely will have to set expandObjectName: false since you will do a static secret name

PrivatePuffin commented 1 year ago

Is your feature request related to a problem?

cloudflareddns does not support to select a pre existent secret for the API Key/ Token. Since i Maintain my Kubernetes using ArgoCD, i don't want clear text Passwords in my Git Inventory

Describe the solution you'd like

I want to be able to select a pre existent secret with selection options for the api key/ token

Describe alternatives you've considered

Using an alternative to the Helm Chart from truecharts, but there is none, so forking it.

Additional context

No response

I've read and agree with the following

  • [x] I've checked all open and closed issues and my request is not there.
  • [x] I've checked all open and closed pull requests and my request is not there.

Due to ArgoCD now having support for normal helm lookups (they basically wrote their own sub-standard helm parser), we do not technically support argoCD. Using TrueCharts with ArgoCD will lead to all sorts of potential issues.

Just adding existing-secret support, which we don't want to add officially at-all though often still possible already, would not be a fix for this problem at all.

hofq commented 1 year ago

Thanks, good to know. i will write my own helm chart then

truecharts-admin commented 1 year ago

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists