daily workflow sometimes setting appVersion incorrectly in chart.yaml

schmitzkr commented 1 year ago

App Name

github ci

Operating System

TrueNAS SCALE 23.10.1

App Version

several

Application Events

I was waiting for the immich chart to get released and noticed that the chart.yaml had the appVersion set to what looks like incorrect value.  The quotes are being removed but in some cases the first digit of the appversion also gets removed.
This then appears to fail the chart install test.
A few PRs where this appears to be the case:
https://github.com/truecharts/charts/pull/15184/commits/05b68994369d537ef047c43d20681d602a517d50
https://github.com/truecharts/charts/pull/15270/commits/3b7f92da1372b802b9192148466f44054e2e5fba
https://github.com/truecharts/charts/pull/15347/commits/dfb25bcea7fffbe287b7836d24368207741d8c30
https://github.com/truecharts/charts/pull/15119/commits/58e93fddca8482f5afe3d42942b1089323f02f54

Application Logs

na

Application Configuration

na

Describe the bug

na

To Reproduce

na

Expected Behavior

na

Screenshots

2023-11-25 08_52_19-chore(deps)_ update container image aeonlucid_impostor to nightly@029aeb0 by tru 2023-11-25 08_53_42-chore(deps)_ update container image aeonlucid_impostor to nightly@029aeb0 · true

Additional Context

na

I've read and agree with the following

[X] I've checked all open and closed issues and my issue is not there.

kqmaverick commented 1 year ago

Known issue already corrected. Recommend close.

schmitzkr commented 1 year ago

ah, I didn't realize this was a known issue, I will close. was there an issue already? I couldn't find one.

PrivatePuffin commented 1 year ago

Just to be clear: This is NOT the "daily workflow" as you can see when you lookup the daily workflow or logs.

schmitzkr commented 1 year ago

oh, I can't seem to see that. what process is it that makes those changes? I see the error is in the pr-validate workflow, but is that also where the appVersion is getting set incorrectly? https://github.com/truecharts/charts/actions/runs/6983958989

PrivatePuffin commented 1 year ago

oh, I can't seem to see that. what process is it that makes those changes? I see the error is in the pr-validate workflow, but is that also where the appVersion is getting set incorrectly? https://github.com/truecharts/charts/actions/runs/6983958989

No, the workflow doing this is not public at this time.

PrivatePuffin commented 1 year ago

(and is also already fixed, as explained by @kqmaverick )

schmitzkr commented 1 year ago

Thank you for clarifying.

truecharts-admin commented 1 month ago

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists

truecharts / public