truecharts / public

Community Helm Chart Repository
https://truecharts.org
GNU Affero General Public License v3.0
1.16k stars 616 forks source link

Unable to upgrade Traefik chart after upgrade to SCALE 22.02-RELEASE #1939

Closed dalgibbard closed 2 years ago

dalgibbard commented 2 years ago

App Name

traefik

SCALE Version

22.02.0

App Version

2.6.0_10.0.58

Application Events

.

Application Logs

.

Application Configuration

.

Describe the bug

When using the TrueNAS UI to upgrade Traefik (from the Truecharts catalog) from 2.6.0_10.0.57 to 2.6.0_10.0.58, I get the error:

  File "/usr/lib/python3/dist-packages/middlewared/plugins/chart_releases_linux/validation.py", line 112, in validate_question
    verrors, parent_value, parent_value[sub_question['variable']], sub_question,
KeyError: 'nodePort'

The TrueNAS UI is configured to us 8443/8080, and Traefik is on 443/80.

To Reproduce

.

Expected Behavior

Upgrade happens without error.

Screenshots

image

Additional Context

.

I've read and agree with the following

dalgibbard commented 2 years ago

I'm also seeing this issue with Plex too - in the config; Nodeport is not set. I haven't changed any config - did something change in the chart that makes this a required value or something?

PrivatePuffin commented 2 years ago

How old is the version you are trying to update to and from? If there has been a major version (first number) bump, that means there might be breaking changes included.

I'm asking this because in current version nodeport isn't even available as a setting anymore unless you explicitly check a special checkbox.

dalgibbard commented 2 years ago

@Ornias1993 Traefik: 2.6.0_10.0.57 to 2.6.0_10.0.58 Plex: 1.25.5.549_8.0.46 to 1.25.5.549_8.0.47

In the settings for these two, I do not have nodeport set: Screenshot_20220223-070603

dalgibbard commented 2 years ago

Ah; it's a bug with the 'Show advanced settings' check box. I had it ticked as shown in the screenshot above. With it unticked, the error goes away and it upgrades correctly.

Which is strange, because node port was empty anyway, and marked as optional :)

PrivatePuffin commented 2 years ago

Anything under advanced or expert checkboxes might or might not break your setup. However: this indeed seems buggy, but is already covered by our refactor roadmap, so closing the issue.

PrivatePuffin commented 2 years ago

@all-contributors please add @dalgibbard for bugs

allcontributors[bot] commented 2 years ago

@Ornias1993

I've put up a pull request to add @dalgibbard! :tada:

truecharts-admin commented 1 year ago

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists