search

truecharts / public

Community Helm Chart Repository
https://truecharts.org
GNU Affero General Public License v3.0
1.15k stars 622 forks source link

Add ffmpeg docker mod to enable ffmpeg within lazylibrarian #3285

Closed frapbod closed 2 years ago

frapbod commented 2 years ago

Is your feature request related to a problem?

Lazylibrarian doesn't come packaged with ffmpeg preinstalled, making it difficult to impossible to postprocess audio book files.

Describe the solution you'd like

Enable the DOCKER_MODS env variable and include linuxserver/mods:lazylibrarian-ffmpeg to include ffmpeg.

Describe alternatives you've considered

I've tried enabling it myself by adjusting the chart itself to include it and have been unable to successfully make it build and have ffmpeg accessible from within the container.

Additional context

I'm pretty sure this chart points towards the linuxserver/lazylibrarian docker image so if that's the case then

lazylibrarian-ffmpeg info

By adding linuxserver/mods:lazylibrarian-ffmpeg to your DOCKER_MODS environment variable you can install ffmpeg into your container on startup. This allows you to use the audiobook conversion features of LazyLibrarian. You can enable it in the Web UI under Settings > Processing > External Programs by setting the ffmpeg path to ffmpeg.

I couldn't tell if that lazylibrarian-ffmpeg container would have to be included as a second image hosted by truecharts or how to add it.

This is the specific docker-mod it looks like it's just a container that calls apt-get update, then apt-get installs ffmpeg.

I've read and agree with the following

PrivatePuffin commented 2 years ago

We prefer not to use S6-based containers (for example: linuxserver.io). Even if we use them, we are permanently looking for beter alternatives.

Hence any s6 (or lsio) only features (such as dockermods) are not going to ever be added by default

You might or might not be able to use the env-var supplied by LSIO. That's not something we control. DockerMods do not, however, require container modifications themselves afaik.

So I'll close this as both "user error" and "won't fix". As the ENVVar can already be set by the user and the fact it doesn't work is most likely not related to us, as we do not control it.

truecharts-admin commented 1 year ago

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists