truecharts / public

Community Helm Chart Repository
https://truecharts.org
GNU Affero General Public License v3.0
1.13k stars 617 forks source link

`monero-node` is barely usable in it's current form #7803

Closed schnerring closed 1 year ago

schnerring commented 1 year ago

App Name

monero-node

SCALE Version

22.02.3

Train Name

incubator

App Version

2.0.9

Latest Available Container Version

latest

Link to container

https://github.com/kannix/monero-full-node

Additional Context

In it's current form the monero-node works, but is barely usable.

The daemon process monerod runs under root, so the blockchain data is written to /root/.bitmonero which isn't persisted to PVC storage because PVC storage targets /home/monero/.bitmonero. This is fixable by changing the following to UID / GID 1000 (user monero):

https://github.com/truecharts/charts/blob/503422bdcc3394bcdaaea4c28282a67807b2d558/charts/incubator/monero-node/values.yaml#L17-L19

I only briefly looked over the upstream code, but couldn't figure out what containerdir1 and containerdir2 are used for. It's not a TrueCharts thing, is it?

https://github.com/truecharts/charts/blob/503422bdcc3394bcdaaea4c28282a67807b2d558/charts/incubator/monero-node/values.yaml#L7-L16

On a side note, the upstream Docker image hasn't been updated in 2 years and probably never will be.

I've read and agree with the following

xstar97 commented 1 year ago

we dont accept gh issues requests for incubator apps for this reason. we have a dedicated channel in our discord for incubator apps.

apps may or may not work at all.

schnerring commented 1 year ago

My bad for missing that. I was actually about to open a PR but then saw how outdated the upstream Docker image was.

schnerring commented 1 year ago

I'm unable to re-join the DC. Who and how do I contact somebody to look into the issue?

xstar97 commented 1 year ago

I'm unable to re-join the DC. Who and how do I contact somebody to look into the issue?

our discord? https://discord.gg/7zVvte539A

schnerring commented 1 year ago

Yes. Can I DM you on Twitter?

PrivatePuffin commented 1 year ago

No, its community build. If you want to discuss incubator discuss it on discord.