docker-compose upgrade losing the Ingress configuration section

qraynaud commented 1 year ago

App Name

docker-compose

SCALE Version

22.12.2

App Version

20.10.21_5.0.0 (and all since then)

Application Configuration

Describe the bug

I upgraded my docker-compose app from 20.10.21_3.0.11 to 20.10.21_5.0.0. I used the Ingress configuration section but it disappeared after upgrade. Right now it does not work anymore.

To Reproduce

I don’t think it’s possible to reproduce since scale does not seem to allow to install old app versions.

Expected Behavior

The Ingress section should still be available.

Additional Context

This is me reopening issue #4453 that was closed because a fix was written by @Ornias1993 (https://github.com/truecharts/charts/commit/664d2b51b9508d615a1a97311b515ab9478ed0a8) but it was never merged and the fix is not part of any open branches anymore.

I've read and agree with the following

[X] I've checked all open and closed issues and my issue is not there.

qraynaud commented 1 year ago

@Ornias1993 you already wrote the fix for this, is it not more logical to just merge it and be done with it instead of letting the commit be garbage collected and having to redo this in Q3?

PrivatePuffin commented 1 year ago

milstones are not set in stone., You're free to submit a PR.

PrivatePuffin commented 1 year ago

Fixed in codebase. Please wait till next release.

truecharts-admin commented 1 year ago

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists

truecharts / public