installing or updating transmission app with `TRANSMISSION_RPC_WHITELIST` set fails

PyroDevil commented 1 year ago

App Name

transmission

SCALE Version

22.12.2

App Version

16.0.15 16.0.16 16.0.17

Application Events

Happens before any application events occur.

Application Logs

Error log when app is installed or updated:

 Error: Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/middlewared/job.py", line 426, in run
    await self.future
  File "/usr/lib/python3/dist-packages/middlewared/job.py", line 461, in __run_body
    rv = await self.method(*([self] + args))
  File "/usr/lib/python3/dist-packages/middlewared/schema.py", line 1186, in nf
    res = await f(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/middlewared/schema.py", line 1318, in nf
    return await func(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/middlewared/plugins/chart_releases_linux/chart_release.py", line 486, in do_create
    await self.middleware.call(
  File "/usr/lib/python3/dist-packages/middlewared/main.py", line 1386, in call
    return await self._call(
  File "/usr/lib/python3/dist-packages/middlewared/main.py", line 1346, in _call
    return await self.run_in_executor(prepared_call.executor, methodobj, *prepared_call.args)
  File "/usr/lib/python3/dist-packages/middlewared/main.py", line 1249, in run_in_executor
    return await loop.run_in_executor(pool, functools.partial(method, *args, **kwargs))
  File "/usr/lib/python3.9/concurrent/futures/thread.py", line 52, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3/dist-packages/middlewared/plugins/chart_releases_linux/helm.py", line 44, in helm_action
    raise CallError(f'Failed to {tn_action} chart release: {stderr.decode()}')
middlewared.service_exception.CallError: [EFAULT] Failed to install chart release: Error: INSTALLATION FAILED: template: transmission/templates/common.yaml:15:30: executing "transmission/templates/common.yaml" at <.Values.chartContext.podCIDR>: can't evaluate field Values in type string

Application Configuration

TRANSMISSION_RPC_WHITELIST = 127.*.*.*,::1,10.*.*.*,172.16.*.*,172.17.*.*,172.18.*.*,172.19.*.*,172.20.*.*,172.21.*.*,172.22.*.*,172.23.*.*,172.24.*.*,172.25.*.*,172.26.*.*,172.27.*.*,172.28.*.*,172.29.*.*,172.30.*.*,172.31.*.*,192.168.*.*
TRANSMISSION_RPC_WHITELIST_ENABLED = True

Describe the bug

Since https://github.com/truecharts/charts/commit/2e0e1275601b7e162013960dbcce6f6bbfbe3bf0 was merged, my transmission app cannot be updated or installed with this configuration.

To Reproduce

Try to install update transmission app, with the TRANSMISSION_RPC_WHITELIST set and enabled, as follows.
See error

Expected Behavior

Successful install/update

Screenshots

n/a

Additional Context

n/a

I've read and agree with the following

[X] I've checked all open and closed issues and my issue is not there.

grvn commented 1 year ago

@PyroDevil please test app version 16.0.27 of transmission. I believe pr #9728, which reverts 2e0e127 should fix your issue.

PyroDevil commented 1 year ago

@grvn, thanks, yes. the update to 16.0.27 now works.

truecharts-admin commented 1 year ago

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists

truecharts / public