search

truedread / netflix-1080p

Chrome extension to play Netflix in 1080p and 5.1
MIT License
2.76k stars 303 forks source link

Update playercore to version 6.0011.853.011 #43

Closed ignaeche closed 5 years ago

ignaeche commented 5 years ago

Due to Netflix updating the playercore version to 6.0011.853.011 (found here) from 6.0011.474.011, if one uses this extension while playing an interactive title like Black Mirror: Bandersnatch, another unrelated segment of the video is shown briefly (a second or less) after selecting a choice.

After doing some testing, this PR fixes the issue mentioned above.
It also closes #39.

Changes

I updated the player to version 6.0011.853.011 and applied the patch to enable 1080p playback. Also included in this pull request is a fix to reenable the bitrate selector using Ctrl+Alt+Shift+S shortcut.

To patch the player, I downloaded the unpatched 6.0011.474.011 version from here to precisely understand the changes made to that player version. I applied the changes to the new player version in a separate commit in order to make them easy to review.

One notable change is in the /watch/ URL test section, where the only parameter of that function is no longer passed the object { SL: { viewables: [...] }, ...}, but instead is passed the object { audioTracks, videoTracks, ... } (or what used to be c.SL.viewables[0]).

Lastly, Netflix added a condition in order to open the bitrate selector that seems to indicate it only works in test accounts. I deleted that condition and the bitrate selector now works as before.

informatorius commented 5 years ago

Does it fix issue https://github.com/truedread/netflix-1080p/issues/36 ?

ignaeche commented 5 years ago

Unfortunately, it does not. Those titles (at least the 2 that are available where I am) make the extension fetch the Edge manifest and fail to play.

truedread commented 5 years ago

I mistakenly didn't check this pull request before updating the playercore myself; however, I attempted to credit you in the commit message for fixing the bitrate selector shortcut. Thanks for your hard work! Sorry I couldn't officially merge this branch :(