truefedex / tv-bro

Simple web browser for android optimized to use with TV remote
https://play.google.com/store/apps/details?id=com.phlox.tvwebbrowser
Other
966 stars 106 forks source link

Full screen stopped working #135

Open Demetto opened 1 year ago

Demetto commented 1 year ago

The update that added the pop-up blocker icon on the bottom toolbar has disabled the browser from expanding videos to full screen on any website. It's not like the other issues where a small screen appears, when I click the full screen button the screen blinks and then nothing happens. I found a work around by pressing Settings on my remote, then going to picture settings, then pressing back on my remote, the fullscreen will suddenly appear. I'm on a Sony x90j smart tv. I tried clearing all the data, uninstalling and re-installing but it didn't work.

Daddy7x6 commented 1 year ago

Ditto - full-screen works on streaming sites, but not on embedded videos on webpages. There's an unsatisfactory workaround by changing user-agent to, for example, Chrome desktop, and clicking the "expand" icon, but that leaves borders on a scrollable webpage. It has to be due to the pop-up blocker addition, as full-screen is, in effect, a pop-up on many websites.

Daddy7x6 commented 1 year ago

Update - I've tried toggling the pop-up blocker off - it's site-based, as it should be, and should enable the full-screen functionality, but doesn't, even after clearing the cache and reloading the webpage. Also, holding the OK key down to get the "open in new tab" menu up has stopped working on some thumbnail links on some webpages on several websites. That's VERY annoying, as it's a major benefit of tabbed browsing.

truefedex commented 1 year ago

Hi. Thank you for feedback. Can you provide example URLs of sites where you experiencing problems? Also android version can help me to reproduce&fix the issue.

ajlai commented 1 year ago

Full screen button on embedded video player doesn’t work for me as well. Example url: (any of the embedded videos) https://twitter.com/Vimeo/status/1615412164407222272/mediaViewer?currentTweet=1615412164407222272&currentTweetUser=Vimeo

I’m using a Chromecast with Google TV Android TV OS Version: 12

TV Bro info below: Version: 1.8.6 com.google.android.webview:109.0.5414.86

MailYouLater commented 1 year ago

I wasn't even able to try using full-screen video at that link. The page doesn't load videos at all if Twitter doesn't think you're in a mobile browser (and what kind of error message is "Hmm...this page doesn’t exist. Try searching for something else.") and I checked it with every UA string offered in TV Bro as well as in multiple other browsers, and while sometimes it loaded videos (and sometimes that error) it never once offered me a full-screen button at all.

Can anyone share a more reliable test link?

Demetto commented 1 year ago

I mostly use TV Bro to watch videos on Rumble. Here is a test link https://rumble.com/v2zgi0-french-bulldog-puppy-vs.-cat.html

My Android TV OS version is 10

MailYouLater commented 1 year ago

That video loads up, plays, has a full screen button, and enters full screen for me.

Affected: No
Device:   MiBox S
OS:       Android TV 9
TV Bro:   v1.8.6
WebView:  108.0.5359.128
takeutiy commented 1 year ago

Hello, Reproducible by this one? https://www3.nhk.or.jp/nhkworld/en/live/

Impossible to enter full screen for me.

TV Bro. v1.8.6 Model. Chromecast OS. Android TV 12 OS Build. STTE.220920.015.A1.9261725

truefedex commented 1 year ago

Thank you for the links. Seems this not relates to tvbro version or android version. This bug relates to WebView system component. Can be reproduced in Android System WebView Canary. I will look for workaround.

Temporary fix for users: disable applications auto-update in android settings and remove updates for "Android System WebView" system application.

takeutiy commented 1 year ago

Thank you for your prompt feedback. After removing updates for Android System WebView, my TV bro crashed. But it worked after re-installed. Looks sufficient for a temporary solution, at least for me :-)

Demetto commented 1 year ago

Removing updates from Webview and reinstalling TV Bro worked for me as well. Thanks!

truefedex commented 1 year ago

Posted issue in google's issue tracker: https://issuetracker.google.com/u/1/issues/266279675

Please do +1 at this issue in google's tracker if you experienced it too.

MailYouLater commented 1 year ago

I got the update to Android System WebView version 109 today, and can verify that it breaks entering full-screen video mode on my MiBox S with Android TV 9 too. As described by OP, after clicking the full-screen button, I can only get a video to actually go full-screen by leaving the app and returning to it. (I hit home then open it again from there.) However, if I hit back while it should be full-screen but isn't, it seems to completely break full-screen video till I actually exit and relaunch the app.

Affected: Yes
Device:   MiBox S
OS:       Android TV 9
TV Bro:   v1.8.6
WebView:  109.0.5814.85

Was also able to test with an Onn 4K TV Box, but not going to update it to 109, it's not mine..

Affected: No
Device:   Onn 4K TV Box
OS:       Android TV 10
TV Bro:   v1.8.6
WebView:  108.0.5359.128
goncalo18s commented 1 year ago

Removing updates from Webview and reinstalling TV Bro worked for me as well. Thanks!

i tried this and didn't work. full screens just doesnt load, only sound

CNDVidel commented 1 year ago

Uninstalling Android System Webview updates & uninstalling/re-installing TV Bro worked for me too on my Nvidia Shield. Thanks!

MailYouLater commented 1 year ago

@goncalo18s Can you check what version numbers TV Bro reports in the VERSION & UPDATES tab of its settings dialog?

For example, this screenshot shows TV Bro version 1.8.6 and WebView version 108.0.5359.128 (a version which is not affected by this bug): Screenshot

goncalo18s commented 1 year ago

https://github.com/truefedex/tv-bro/issues/145

Quikfix73 commented 1 year ago

My MiBox had an update to Android System WebView version 111.0.5563.58 today and I updated and tested it and the full screen is working again.

I did more testing and as of right now full screen works the first time and if you try it again on full screen it doesn't work but if I reload the streaming page in most cases I am able to get it to full screen again so it is not working perfectly as it did before but at least I can get full screen now.

takeutiy commented 1 year ago

Reinstalled TVbro to the version 1.8.6 and updated to Android System WebView version 111.0.5563.58. Full screen seems to work at once. But it can't enter to the full screen since I enter to the same page by reloading Or another case is it's impossible to restore to the embedded screen again by the back button.

You can try it. In this example, once it works. But after reloading the page, can't enter to the full screen. https://www3.nhk.or.jp/nhkworld/en/live/

My device is Chromecast with Google TV.

mpaunovic commented 1 year ago

It seems with the latest WebView version 113.x.x.x update the full screen issue has been fixed. Can anybody confirm this?

truefedex commented 1 year ago

@mpaunovic Yes, it looks like they finally fixed it.