search

truekendor / better-ccc-extension

8 stars 4 forks source link

Material covering eval #26

Open MrBrain295 opened 2 weeks ago

MrBrain295 commented 2 weeks ago

With the latest version of the extension from the main branch the eval gets covered by material. image

truekendor commented 2 weeks ago

@MrBrain295 Thanks for the issue Working on that rn

MrBrain295 commented 2 weeks ago

I'm trying to build the extension for Firefox but it wont build and I don't have much Typescript or NPM experience.

MrBrain295 commented 2 weeks ago

@truekendor I don't have much experience with browser extensions do you know what command builds the compiled extention?

truekendor commented 2 weeks ago

@MrBrain295 Do you have node js and typescript installed?

MrBrain295 commented 2 weeks ago

yes

MrBrain295 commented 2 weeks ago

on my pr i added a command that compiles it but it still dosen't make an extention

truekendor commented 2 weeks ago

@MrBrain295 I just do it by hand with chrome I can write how if you are interested

MrBrain295 commented 2 weeks ago

i use firefox so i was wondering how to do that

truekendor commented 2 weeks ago

For me it's easier to pack the extension using chrome Unfortunately, I don’t know other ways :(

MrBrain295 commented 2 weeks ago

dang

truekendor commented 2 weeks ago

@MrBrain295 I think this might do the trick https://extensionworkshop.com/documentation/publish/package-your-extension/

Also this one looks promising https://discourse.mozilla.org/t/tools-for-building-xpi-files/65432

truekendor commented 2 weeks ago

So you just send .zip file with your addon to the developer hub

MrBrain295 commented 2 weeks ago

I figured it out

MrBrain295 commented 2 weeks ago

give me a couple minutes and ill have a pr