We want a single place to modify to add new alarms and modifying options on alarm creation. To this end alarm-config.mts was created and pushed to the develop branch. The following needs to be completed to complete the conversion:
1) Modify all modules so the alarm configurations are in MetricAlarmConfigs.
2) Modify how Anomaly alarms work since they will follow the same conventions as normal metric alarms going forward.
3) Add additional unit tests to alarm-config.test.mts.
4) Update the README accordingly
5) Update the CHANGELOG.md entry for the upcoming release
Your PR must have approval from the team leads who own the alarms. I recommend you issue a single PR per module as you clean things up.
Be aware this change breaks backward compatibility for anomaly alarms. Before these changes are merged, you are also required to present an upgrade plan to avoid alarms from breaking and a timeline on how this will be rolled out one released.
We want a single place to modify to add new alarms and modifying options on alarm creation. To this end alarm-config.mts was created and pushed to the develop branch. The following needs to be completed to complete the conversion:
1) Modify all modules so the alarm configurations are in MetricAlarmConfigs. 2) Modify how Anomaly alarms work since they will follow the same conventions as normal metric alarms going forward. 3) Add additional unit tests to alarm-config.test.mts. 4) Update the README accordingly 5) Update the CHANGELOG.md entry for the upcoming release
Your PR must have approval from the team leads who own the alarms. I recommend you issue a single PR per module as you clean things up.
Be aware this change breaks backward compatibility for anomaly alarms. Before these changes are merged, you are also required to present an upgrade plan to avoid alarms from breaking and a timeline on how this will be rolled out one released.