search

truemped / supercell

supercell
http://supercell.readthedocs.org
Apache License 2.0
7 stars 10 forks source link

Fixed Logging #2

Closed truemped closed 11 years ago

truemped commented 11 years ago

Logging should be standardized within supercell. The idea is that the user should only provide a base log file name that will be used for configuring the rotating file handler. It would also be great, if the requests are identifiable inside the logs, i.e. they should get some kind of request id.

The user should then be allowed to access the logs everywhere maybe using self.log(), where self is the request handler. Logging through this should then also add some more data like the request id.

All other uncaught exceptions should also be logged in order to provide some nicer insights for debugging or testing these errors.

drotschmann commented 11 years ago

In addition, I propose to make use of the additional keyword argument when raising Error, Ok or OkCreated, so that supercell logs the additional information provided.

truemped commented 11 years ago

Logging of additional keywords to Error, Ok and such has been fixed in a480fea