search

truenas / charts

TrueNAS SCALE Apps Catalogs & Charts
BSD 3-Clause "New" or "Revised" License
258 stars 253 forks source link

Update Tdarr to 2.20.01 #2586

Closed Urkaz closed 1 week ago

Urkaz commented 2 weeks ago

2.20.01 is currently the last version available.

https://github.com/haveagitgat/Tdarr/pkgs/container/tdarr https://hub.docker.com/r/haveagitgat/tdarr/tags

Thanks :)

stavros-k commented 2 weeks ago

Hello, please see #2583

Urkaz commented 2 weeks ago

Oh, I didn't see that. That will allow automatic updates so there is no need for this PR?

stavros-k commented 2 weeks ago

Oh, I didn't see that. That will allow automatic updates so there is no need for this PR?

Yes that's correct!

swensorm commented 2 weeks ago

Hmm... Did I miss something though? 2.21.01 was also released today but I don't see a PR getting created that includes either update 😕

swensorm commented 2 weeks ago

Oh, shoot, I see the issue. Tdarr wonderfully versions things as "2.21.01" but the parsed version is "2.21.1". On line 22 it tries to index the tags array with "2.21.1" which doesn't exist.

~Suggestions on how to fix?~ 🤔

Update: I took a stab at a fix and submitted PR https://github.com/truenas/charts/pull/2604 🙏

Urkaz commented 1 week ago

Ok, I'll close this then. Thank you both for your work, stavros-k and swensorm! :)

swensorm commented 1 week ago

Woohoo! Looks to have worked 🎉

https://github.com/truenas/charts/pull/2616