trueos / trueos-core

59 stars 18 forks source link

Life Preserver should replicate zvols with volmode=none #302

Open asomers opened 7 years ago

asomers commented 7 years ago

Currently, when Life Preserver replicates my zvol-containing pool to the server, the server logs many error messages like "g_dev_taste: make_dev_p() failed (gp->name=zvol/tank/backup/lp/threonine.lauralan.noip.me/bhyve/ubuntux86/disk0@auto-2017-01-17-19-00-00s5, error=63)". Those errors are probably happening because server is trying to create a cdev with a path that is too long. But there's no need for the server to create the cdev in the first place. Life Preserver should be setting the zvol's volmode property to "none" when it backs it up so that the server won't attempt to create a cdev for it. Life Preserver can store the original volmode in a custom property like "lifepreserver-prop:volmode" so it can be restored.

Mrt134 commented 7 years ago

Apologies for the inactivity. We'll need to reverify this is still an issue, then look into the fix.

asomers commented 7 years ago

I can confirm that it's still happening using the latest TrueOS. I haven't tried to backup a new zvol for months, but my old zvols still have volmode=default.

Mrt134 commented 7 years ago

Ok, thanks for the update!