Closed sfc-gh-dkurokawa closed 3 days ago
I'm in favor of option 3 (keep only the root lockfile and add the others to gitignore), which requires some of option 4 for the removed lockfiles. The sub-lockfiles are only needed when building the package, but our dev environment only depends on the root one. The sub-lockfiles also much faster to create from scratch than the root one (30s vs 2-3 min).
Closed in favor of https://github.com/truera/trulens/pull/1653/files
Description
Remove
poetry.lock
files. I removed them for a few reasons:poetry.lock
files.That said, it does seem like it'll make the pipeline slower now since it has to resolve the dependencies (it seems to take 6-7 min longer in my sample size of 1). That's a trade-off I'm willing to accept but not sure of the reviewers.
TBH, the main issue I have with them is that I keep seeing them in so many PRs and it's annoying because of how many there are. AFAICT here are the ways we can go:
poetry.lock
in the root directory. I don't know why we have the other ones, it's not like they're used AFAIU? @coreyhu correct me if I'm wrong.Other details good to know for developers
Type of change