trufae / Therm

An iTerm2 fork with focus on minimalism and better defaults
GNU General Public License v2.0
301 stars 9 forks source link

Therm crashes whit zsh #27

Closed joanbono closed 6 years ago

joanbono commented 6 years ago

Hi @trufae

Therm crashes when executing zsh.

While doing:

jbono@MacBook [~]> zsh

Therm closes immediately and suggests to send a crash report.

I don't know if this is useful for you but I pasted the report to paste.ee

Edit:

Also crashes with a simple echo:

jbono@MacBook [~]> echo "Hola"
trufae commented 6 years ago

Please specify the version

On 27 Nov 2017, at 15:46, Joan Bono notifications@github.com wrote:

Hi @trufae

Therm crashes when executing zsh.

While doing:

jbono@MacBook [~]> zsh Therm closes immediately and suggests to send a crash report.

I don't know if this is useful for you but I pasted the report to paste.ee

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

joanbono commented 6 years ago

It's v0.0.7, downloaded few minutes ago.

trufae commented 6 years ago

Happens in 0.0.6 too?

On 27 Nov 2017, at 16:06, Joan Bono notifications@github.com wrote:

It's v0.0.7, downloaded few minutes ago.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

joanbono commented 6 years ago

Nope, v.0.0.6 works like a charm.

trufae commented 6 years ago

cant reproduce with 0.0.7, but seems like something related to the commandline parsing magic that iterm does and i have purged half of it and some selectors are still being called. ill try to do a blind fix, can you test from git? or do you want me to push a build here?

trufae commented 6 years ago

try this build, i did a blind fix

Therm.app.zip

joanbono commented 6 years ago

It works now! 😃

Thanks @trufae !

trufae commented 6 years ago

Thanks for testing :) ill push another release just for this.

On 27 Nov 2017, at 17:21, Joan Bono notifications@github.com wrote:

It works now! 😃

Thanks @trufae !

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

trufae commented 6 years ago

https://github.com/trufae/Therm/releases/tag/0.0.8

joanbono commented 6 years ago

v0.0.8 downloaded and tested. Everything works as expected 👍

Thanks!