trufae
commented
6 years ago seems like this is a race condition taht should be reproducible with iterm, did you tried?
On 31 Jan 2018, at 18:47, MindTooth notifications@github.com wrote:
setProfile
Closed MindTooth closed 6 years ago
trufae
commented
6 years ago seems like this is a race condition taht should be reproducible with iterm, did you tried?
On 31 Jan 2018, at 18:47, MindTooth notifications@github.com wrote:
setProfile
MindTooth
commented
6 years ago Reverted now to 0.1.2, and haven't had a crash yet. Replicating the steps from before.
trufae
commented
6 years ago let me know if you find the offending commit.
the affected code is in your crashlog (3 com.pancake.therm 0x000000010eecf2ab -[PTYSession setProfile:] + 159 )
are you using a special profile configuration or you have a clean environment when testing this?
On 31 Jan 2018, at 20:28, MindTooth notifications@github.com wrote:
Reverted now to 0.1.2, and haven't had a crash yet. Replicating the steps from before.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/trufae/Therm/issues/38#issuecomment-362043440, or mute the thread https://github.com/notifications/unsubscribe-auth/AGIjGzeLGrSVscEs0lT5qJYcM8jnKWPTks5tQL7ygaJpZM4R0YZz.
trufae
commented
6 years ago i can reproduce it
trufae
commented
6 years ago
Application Specific Information:
Crashing on exception: -[__NSSetI rangeOfString:]: unrecognized selector sent to instance 0x604000011cc0
Application Specific Backtrace 1:
0 CoreFoundation 0x00007fff4bafefcb __exceptionPreprocess + 171
1 libobjc.A.dylib 0x00007fff727a0c76 objc_exception_throw + 48
2 CoreFoundation 0x00007fff4bb97a24 -[NSObject(NSObject) doesNotRecognizeSelector:] + 132
3 CoreFoundation 0x00007fff4ba75610 ___forwarding___ + 1456
4 CoreFoundation 0x00007fff4ba74fd8 _CF_forwarding_prep_0 + 120
5 Therm 0x00000001082cc806 -[VT100Terminal setTermType:] + 56
6 Therm 0x000000010835738a -[PTYSession setPreferencesFromAddressBookEntry:] + 3389
7 Therm 0x000000010846d4f6 -[PseudoTerminal setupSession:title:withSize:] + 1703
8 Therm 0x0000000108471ef3 -[PseudoTerminal addSessionInNewTab:] + 131
9 Therm 0x00000001084713b0 -[PseudoTerminal createTabWithProfile:withCommand:] + 797
10 Therm 0x00000001083e18aa -[iTermController launchBookmark:inTerminal:withURL:hotkeyWindowType:makeKey:canActivate:command:block:] + 1812
11 Therm 0x00000001083e0ae6 -[iTermController launchBookmark:inTerminal:] + 43
12 Therm 0x000000010848b5c1 -[iTermApplicationDelegate newWindow:] + 162
13 AppKit 0x00007fff497f375a -[NSApplication(NSResponder) sendAction:to:from:] + 312
14 AppKit 0x00007fff492885f7 -[NSMenuItem _corePerformAction] + 323
15 AppKit 0x00007fff4928837f -[NSCarbonMenuImpl performActionWithHighlightingForItemAtIndex:] + 114
16 AppKit 0x00007fff492871e3 -[NSMenu performKeyEquivalent:] + 363
17 AppKit 0x00007fff497f23c1 routeKeyEquivalent + 884
18 AppKit 0x00007fff497ef8f5 -[NSApplication(NSEvent) sendEvent:] + 1041
19 Therm 0x000000010830256c -[iTermApplication sendEvent:] + 264
20 AppKit 0x00007fff49050d9d -[NSApplication run] + 812
21 AppKit 0x00007fff4901ff1a NSApplicationMain + 804
22 Therm 0x000000010822a2de main + 110
23 libdyld.dylib 0x00007fff73390115 start + 1Good. So I'm not the only one.
P.S.: What about enabling Travis on the repo? Just needs to register the project I guess.
trufae
commented
6 years ago wanna send a pr enabling travis here?
can you confirm master works for you? i can upload a build if you want.
MindTooth
commented
6 years ago I can tro compile myself first. Give me 2 sec
Travis is already enabled I believe (the old config files lies there). You only need to add the app itself to the GitHub repo.
Ref. Settings > Integrations & services > Add service > Pick Travis CI.
trufae
commented
6 years ago MindTooth
commented
6 years ago Nice. Pushed the update to Caskroom as well. Installed it via it.
trufae
commented
6 years ago Thanks!!
On 31 Jan 2018, at 22:48, MindTooth notifications@github.com wrote:
Nice. Pushed the update to Caskroom as well. Installed it via it.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.
MindTooth
commented
6 years ago Been doing some testing with Travis-CI. But I encounter a issue. https://travis-ci.org/MindTooth/Therm/
Had to test it out yesterday after we spoke about it :P
cd /Users/travis/build/MindTooth/Therm
export MACOSX_DEPLOYMENT_TARGET=10.11
/Applications/Xcode-9.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -arch x86_64 -bundle -isysroot /Applications/Xcode-9.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -L/Users/travis/Library/Developer/Xcode/DerivedData/Therm-cxetksbtsmovnqfaxghrssmusveg/Build/Products/Development -F/Users/travis/Library/Developer/Xcode/DerivedData/Therm-cxetksbtsmovnqfaxghrssmusveg/Build/Products/Development -F/Applications/Xcode-9.2.app/Contents/Developer/Library/Frameworks -F/Users/travis/build/MindTooth/Therm -F/Applications/Xcode-9.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks -filelist /Users/travis/Library/Developer/Xcode/DerivedData/Therm-cxetksbtsmovnqfaxghrssmusveg/Build/Intermediates.noindex/Therm.build/Development/ThermXCTests.build/Objects-normal-asan/x86_64/ThermXCTests.LinkFileList -Xlinker -rpath -Xlinker @executable_path/../Frameworks -Xlinker -rpath -Xlinker @loader_path/../Frameworks -mmacosx-version-min=10.11 -bundle_loader /Users/travis/Library/Developer/Xcode/DerivedData/Therm-cxetksbtsmovnqfaxghrssmusveg/Build/Products/Development/Therm.app/Contents/MacOS/Therm -Xlinker -object_path_lto -Xlinker /Users/travis/Library/Developer/Xcode/DerivedData/Therm-cxetksbtsmovnqfaxghrssmusveg/Build/Intermediates.noindex/Therm.build/Development/ThermXCTests.build/Objects-normal-asan/x86_64/ThermXCTests_lto.o -Xlinker -export_dynamic -Xlinker -no_deduplicate -fobjc-link-runtime -fsanitize=address -framework XCTest -lThermSharedARC -lThermShared -Xlinker -dependency_info -Xlinker /Users/travis/Library/Developer/Xcode/DerivedData/Therm-cxetksbtsmovnqfaxghrssmusveg/Build/Intermediates.noindex/Therm.build/Development/ThermXCTests.build/Objects-normal-asan/x86_64/ThermXCTests_dependency_info.dat -o /Users/travis/Library/Developer/Xcode/DerivedData/Therm-cxetksbtsmovnqfaxghrssmusveg/Build/Products/Development/Therm.app/Contents/PlugIns/ThermXCTests.xctest/Contents/MacOS/ThermXCTests
Undefined symbols for architecture x86_64:
"_OBJC_CLASS_$_VT100RemoteHost", referenced from:
objc-class-ref in iTermShellHistoryTest.o
objc-class-ref in iTermToolbeltTest.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
2018-02-01 10:15:25.888 xcodebuild[5948:12313] Error Domain=IDETestOperationsObserverErrorDomain Code=14 "Test operation was canceled. If you believe this error represents a bug, please attach the log file at /var/folders/bb/n7t3rs157850byt_jfdcq9k80000gn/T/com.apple.dt.XCTest/IDETestRunSession-B2958E39-32C4-4884-B176-F6CC4A46D280/ThermXCTests-8B270D16-739A-4DA9-8711-6AA58C448B40/Session-ThermXCTests-2018-02-01_101356-o7DnH7.log" UserInfo={NSLocalizedDescription=Test operation was canceled. If you believe this error represents a bug, please attach the log file at /var/folders/bb/n7t3rs157850byt_jfdcq9k80000gn/T/com.apple.dt.XCTest/IDETestRunSession-B2958E39-32C4-4884-B176-F6CC4A46D280/ThermXCTests-8B270D16-739A-4DA9-8711-6AA58C448B40/Session-ThermXCTests-2018-02-01_101356-o7DnH7.log}
Testing failed:
"_OBJC_CLASS_$_VT100RemoteHost", referenced from:
Linker command failed with exit code 1 (use -v to see invocation)
** TEST FAILED **The command is taken from Apple: https://developer.apple.com/library/content/technotes/tn2339/_index.html#//apple_ref/doc/uid/DTS40014588-CH1-UNIT
# .travis.yml
# System Image
language: objective-c
# Build Script
script:
- xcodebuild clean test -scheme iTerm2 -destination 'platform=macOS,arch=x86_64'
CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO
Seems to randomly crash. It crashes after I've opened the windows twice and closed them twice using
exit. And then switching between other windows (Safarai & Mail).Using the latest 0.1.3. Not sure I had the issue with 0.1.2. I'll try to revert to see if it persist.