search

trufae / Therm

An iTerm2 fork with focus on minimalism and better defaults
GNU General Public License v2.0
300 stars 9 forks source link

Cmd-H doesn't hide Therm windows #40

Open jedisct1 opened 6 years ago

jedisct1 commented 6 years ago

Hi,

Apologies if this is a duplicate.

Cmd-H doesn't seem to do anything; at least it doesn't hide the Therm windows.

Therm 0.1.5 installed by Homebrew cask, macOS 10.13.4.

trufae commented 6 years ago

I removed it because it causes more confussion and problems than being a useful feature imho.

Do you use this keybinding frequently? One option to reintroduce this would be to make it work with cmd-shift-h

On 22 Feb 2018, at 23:00, Frank Denis notifications@github.com wrote:

Hi,

Apologies if this is a duplicate.

Cmd-H doesn't seem to do anything; at least it doesn't hide the Therm windows.

Therm 0.1.5 installed by Homebrew cask, macOS 10.13.4.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

jedisct1 commented 6 years ago

Yes! I use it all the time, with all apps.

jedisct1 commented 6 years ago

Shift-Cmd-H would cause even more confusion IMHO, since this is typically used to access the history in web browsers.

But an option to restore Cmd-H would be great. I'm not convinced that this is causing confusion, since this is a pretty much universal shortcut. Therm is the first tool I stumbled upon that doesn't handle it.

trufae commented 6 years ago

The thing is that i use cmd+JK to select the pane, like in DWM, and CMD+H and CMD+L make more sense to be something related to left and right than just “HIDE”, at least from the perspective of a UNIX user, not a Mac one.

Will think about this, but i never use CMD+H and find it quite counter-intuitive, in fact most ppl i know is very confused when using Mac for the first time because of things like this

On 23 Feb 2018, at 09:52, Frank Denis notifications@github.com wrote:

Shift-Cmd-H would cause even more confusion IMHO, since this is typically used to access the history in web browsers.

But an option to restore Cmd-H would be great. I'm not convinced that this is causing confusion, since this is a pretty much universal shortcut. Therm is the first tool I stumbled upon that doesn't handle it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/trufae/Therm/issues/40#issuecomment-367947787, or mute the thread https://github.com/notifications/unsubscribe-auth/AGIjG-rtCr0PXxWBQ4hNpmI-NC2OSvEPks5tXnw-gaJpZM4SQDlI.

trufae commented 6 years ago

but yeah, i also understand the consistency with the mac ecosystem is important

On 23 Feb 2018, at 09:52, Frank Denis notifications@github.com wrote:

Shift-Cmd-H would cause even more confusion IMHO, since this is typically used to access the history in web browsers.

But an option to restore Cmd-H would be great. I'm not convinced that this is causing confusion, since this is a pretty much universal shortcut. Therm is the first tool I stumbled upon that doesn't handle it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/trufae/Therm/issues/40#issuecomment-367947787, or mute the thread https://github.com/notifications/unsubscribe-auth/AGIjG-rtCr0PXxWBQ4hNpmI-NC2OSvEPks5tXnw-gaJpZM4SQDlI.

zakx commented 6 years ago

I also miss this feature.

jedisct1 commented 6 years ago

I went back to iTerm. Cmd-H not working was a dealbreaker.

trufae commented 6 years ago

:(

On 31 May 2018, at 13:35, Frank Denis notifications@github.com wrote:

I went back to iTerm. Cmd-H not working was a dealbreaker.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/trufae/Therm/issues/40#issuecomment-393502003, or mute the thread https://github.com/notifications/unsubscribe-auth/AGIjG4npHNUwLhXwviyqnGUGyF8GHMtLks5t39VogaJpZM4SQDlI.

xsb commented 6 years ago

I also use Cmd-H constantly with all apps and I am missing it in Therm. This is the first app I found that does not handle it correctly.

trufae commented 6 years ago

:(

ok will probably bring it back, because i dont use cmd+H at all , but sometimes it fuckedup my workflow when typing fast and then OH THERES NO WINDOW ANYWHERE. i stay in the terminal 90% of the time, so i dont want a keybinding which is based on HJKL to mess with that

On 20 Jun 2018, at 11:34, Xavi Soler notifications@github.com wrote:

I also use Cmd-H constantly with all apps and I am missing it in Therm. This is the first app I found that does not handle it correctly.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/trufae/Therm/issues/40#issuecomment-398687110, or mute the thread https://github.com/notifications/unsubscribe-auth/AGIjG4EyYOHKTxQf6aUfkc_5PyL0GEx3ks5t-hcUgaJpZM4SQDlI.