search

trufae / Therm

An iTerm2 fork with focus on minimalism and better defaults
GNU General Public License v2.0
300 stars 9 forks source link

Fullscreen does not send Therm to new space #52

Open xsb opened 6 years ago

xsb commented 6 years ago

I recently updated from 0.1.2 to 0.1.8 so I am not sure if this bug is new or not.

When I switch to fullscreen with CMD+ENTER, Therm does not go to a new space (available from the space bar on top).

trufae commented 6 years ago

its on purpose. the fullscreen into a new space is slow and inefficient. Never liked such behaviour on mac, and i prefer to keep it like this in Therm because i want to have fullscreen terminals and be able to have other windows in the same space as well.

On 20 Jun 2018, at 11:39, Xavi Soler notifications@github.com wrote:

I recently updated from 0.1.2 to 0.1.8 so I am not sure if this bug is new or not.

When I switch to fullscreen with CMD+ENTER, Therm does not go to a new space (available from the space bar on top).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/trufae/Therm/issues/52, or mute the thread https://github.com/notifications/unsubscribe-auth/AGIjG0yntMGB3gkOpApmgqYU2NF-IWZBks5t-hhTgaJpZM4Uu7-9.

vidaru commented 6 years ago

Would be nice to have the option of still keeping the default macOS behaviour. I like this project but this "feature" is a deal breaker for me.

trufae commented 6 years ago

Maybe i can just a toggle to:

We can call it mac mode. For all those people who dont come from linux. Wonder if all those settings that many ppl complain are fine with all you as a single option instead of 3 separate checks

On 21 Jun 2018, at 13:49, vidaru notifications@github.com wrote:

Would be nice to have the option of still keeping the default macOS behaviour. I like this project but this "feature" is a deal breaker for me.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

xsb commented 6 years ago

+1 to put it together as a single option

vidaru commented 6 years ago

I’m for the single option idea.

trufae commented 5 months ago

I will take this into consideration when i find time to refactor the settings panel. Sorry for the late reply. moving to mojave and the latest xcode introduced a bunch of regressions, and i think that it will slowly get better from now on.