search

trufae / Therm

An iTerm2 fork with focus on minimalism and better defaults
GNU General Public License v2.0
300 stars 9 forks source link

Therm doesn't relinquish keyboard focus when switching desktops #55

Open sleach opened 6 years ago

sleach commented 6 years ago

I have Chrome setup to always be on Desktop 1, and Therm always on Desktop 2. I have Ctrl-1 mapped to switch to Desktop 1, Ctrl-2 to switch to Desktop 2, etc. So when I switch to Desktop 1 using that key combo, Chrome becomes the active app, taking keyboard input etc.

If I am using Therm on Desktop 2, and then I hit Ctrl-1 to switch to Desktop 1/Chrome, Chrome becomes the "active window" in that the desktop changes, Chrome becomes visible, the System Menu changes to Chrome etc. but Therm is still the target of any keyboard presses. i.e. if I hit Cmd-t for a new tab in Chrome, focus switches back to Therm and a new tab is created there etc. Keyboard focus should be sent to Chrome as soon as I switch away from Therm.

trufae commented 6 years ago

This bug is also in iTerm2. Will be good to report it there and backport the patch qhen fixed.

I’ll try to fix some of those mouse-over bugs in therm when i have some spare time(R) and push the fix into iterm later unless they fix that before.

The reason for making therm mouse over only was to make all those bugs more visible for people to care and fix.

Thanks for reporting!

On 2 Aug 2018, at 16:16, Sean Leach notifications@github.com wrote:

I have Chrome setup to always be on Desktop 1, and Therm always on Desktop 2. I have Ctrl-1 mapped to switch to Desktop 1, Ctrl-2 to switch to Desktop 2, etc. So when I switch to Desktop 1 using that key combo, Chrome becomes the active app, taking keyboard input etc.

If I am using Therm on Desktop 2, and then I hit Ctrl-1 to switch to Desktop 1/Chrome, Chrome becomes the "active window" in that the desktop changes, Chrome becomes visible, the System Menu changes to Chrome etc. but Therm is still the target of any keyboard presses. i.e. if I hit Cmd-t for a new tab in Chrome, focus switches back to Therm and a new tab is created there etc. Keyboard focus should be sent to Chrome as soon as I switch away from Therm.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

sleach commented 6 years ago

Happy to help. Though, I use iTerm2 mainly and I haven't ran into this bug.

trufae commented 6 years ago

Did u tried with mouseover option set in iterm?

On 2 Aug 2018, at 18:53, Sean Leach notifications@github.com wrote:

Happy to help. Though, I use iTerm2 mainly and I haven't ran into this bug.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

sleach commented 6 years ago

I don't use the mouseover option in iTerm2, I don't use it in Therm either (I verified this problem still happens even with that setting disabled in Therm)

trufae commented 6 years ago

You use it in therm. Basically because its hardcoded and the settings are ignored :p

On 3 Aug 2018, at 16:23, Sean Leach notifications@github.com wrote:

I don't use the mouseover option in iTerm2, I don't use it in Therm either (I verified this problem still happens even with that setting disabled in Therm)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.