trufae / Therm

An iTerm2 fork with focus on minimalism and better defaults
GNU General Public License v2.0
300 stars 9 forks source link

App versions do not match releases #71

Closed vitorgalvao closed 5 months ago

vitorgalvao commented 2 years ago

To accurately display version information, macOS apps need to have the CFBundleVersion and CFBundleShortVersionString tags in Info.plist.

Therm has them, but they’re set to unknown (literally that string, CFBundleGetInfoString is the same).

If versions aren’t set during the build process, they can be added after it’s done by directly editing the Info.plist:

# Change these values
app_path='/PATH/TO/APP/HERE'
app_version='VERSION NUMBER HERE'

# Keep these as they are
/usr/libexec/PlistBuddy -c "Set :CFBundleVersion string ${app_version}" "${app_path}/Contents/Info.plist"
/usr/libexec/PlistBuddy -c "Set :CFBundleShortVersionString string ${app_version}" "${app_path}/Contents/Info.plist"

That would use the same version number for both fields. Technically they should be different, but that’s a secondary concern. An accurate version number is important for macOS to know which app to open in ambiguous situations; for users who expect the information available via the Finder; and for interoperability with other apps.

core-code commented 8 months ago

still broken in 0.6

Screenshot 2023-12-05 at 17 54 57 Screenshot 2023-12-05 at 17 54 44
trufae commented 8 months ago

Would you like to submit a PR?

core-code commented 5 months ago

thanks!