search

trufanov-nok / scantailor-universal

ScanTailor Universal - a fork based on Enhanced+Featured+Master versions of ST
http://scantailor.org
Other
181 stars 16 forks source link

Autosave functionality bug #117

Open maximka1812 opened 1 year ago

maximka1812 commented 1 year ago

With new unsaved project and activated autosaving ST must store project in the input folder with UnnamedAutoSave.Scantailor name. After recent crash (with 5 minute autosave enabled and much more time that passed since the start) I never saw such file in input dir. I checked lot of folders where I worked quite long time before saving project and found only one case where it saved such unnamed project by itself. It seems to be related with how QT timer object is used (wither wrong setting or never activated setting or wrong or absent initialization), and, by idea it must also affect usual auto saving.

Btw, total crash happened in the speckles removal tab.

trufanov-nok commented 1 year ago

First of all it's not supposed to crash. Autosave function was adopted from ScanTailor Plus fork. It's quite an old code and I personally don't use this feature in my work, so I could miss some inconsistent behaviour.

I checked lot of folders where I worked quite long time before saving project and found only one case where it saved such unnamed project by itself.

If you saved a project properly and it has a normal project filename, the UnnamedAutoSave.Scantailor will be deleted. AutoSave tries to delete UnnamedAutoSave.Scantailor file each time it saves a project with a proper filename.

Perhaps I found a bug. It seems the timer is put on pause in New project dialog and not unpaused after that.

maximka1812 commented 1 year ago

May be cause of crash is that I have None set as default in despeckling :-)

Also it must be some place where timer starts to work again, may be if you go to settings?

Thanks for explanation I now get why I see so few Unnamed projects now.

trufanov-nok commented 1 year ago

Should be fixed with the latest commit. Are you a linux user? If so you can check it. I hate build Windows version - it's quite difficult.

maximka1812 commented 1 year ago

Thanks.

I am exactly Windows user (but sometimes use WSL or manage web server :-))

Let me know how to build Windows version. I saw some instructions for Advanced branch, but nothing for this one.

I can help you here and make regular compiled x64 versions.

trufanov-nok commented 1 year ago

Do you know "DevOps"? I mean TravisCI and other wonderful tools that could build free opensource project in the cloud for Windows after each commit? I saw some projects use their results as a nightly builds: https://github.com/icsharpcode/AvaloniaILSpy/actions?query=workflow%3A%22Build+AvaloniaILSpy%22+branch%3Amaster+is%3Asuccess That would be interesting to setup for this project even it's not impossible to get apps with WinXP suport and probably 32-bit binaries from it.

Otherwise - let me know if you are able to build the ST Advanced fork. I guess it will take you a day to clear up. If you are - I guess you would have a 90% ready environment to build STU and it would worth to consult this effort.