truffle-box / metacoin-box

MetaCoin smart contracts example box
MIT License
123 stars 93 forks source link

camelCase variable names, use of async/await, added comments #6

Closed dstawinski closed 5 years ago

dstawinski commented 6 years ago

Made use of async/await and arrow functions in test/metacoin.js. Also changed variables to const and names to camelCase to follow guidelines. Added some comments to improve readability.

eggplantzzz commented 5 years ago

@dstawinski This looks like a good update. Sorry for the delay in getting around to looking at this.

eggplantzzz commented 5 years ago

@dstawinski Do you have time to resolve this conflict? If so we can merge this soon. The requires were just updated to use the preferred syntax of requiring the contract name rather than the file. If you have any ?'s then let me know.

eggplantzzz commented 5 years ago

Also if you don't have time let me know and I'll go ahead and resolve the conflict.

dstawinski commented 5 years ago

Hello, sorry for delay as it was quick conflict but I hadn't seen the mail till today.

eggplantzzz commented 5 years ago

Thanks again @dstawinski !