truffle-box / optimism-box

Truffle box with code to start working with Optimism L2
MIT License
23 stars 14 forks source link

Remove module.exports.db #10

Closed qbzzt closed 3 years ago

qbzzt commented 3 years ago
  1. Put the mnemonic for optimistic_ethereum in this file. It is not a secret, so there is no reason to hide it. For usability reasons, it is much better to have it in a file that developers get when they clone the repository rather than require them to add it manually.

  2. Disabled module.exports.db in both configuration files.

This solves #9

fainashalts commented 3 years ago

Thanks for this PR @qbzzt! I'm merging it but with the caveat that I will be re-enabling DB soon- the issue you mentioned is real but should be resolved in the near future. I really appreciate you taking the time to write this up and would love any additional feedback you have for making this box better and more user-friendly!