truffle-box / react-box

Truffle, Webpack and React boilerplate.
https://truffle-box.github.io/
MIT License
736 stars 251 forks source link

migrations files #46

Closed OTTTO closed 6 years ago

OTTTO commented 6 years ago

This is in regards to all migrations files across all Truffle Boxes.

In the Truffle Documentation it states – "The name specified should match the name of the contract definition within that source file. Do not pass the name of the source file, as files can contain more than one contract."

Yet in all of these boxes, it shows the file name.

Perhaps I am confused, but if I am right that this is the wrong way to do it based on the documentation, I think this is very problematic as I've seen projects in "the wild", that do this as well; but, they are even doing this on files with multiple contracts!

I believe that (unfortunately) most people use the Truffle Boxes as a template as opposed to thoroughly reading the documentation, so I propose that all of the migrations files be changed