search

trufflesuite / drizzle-legacy

Reactive Ethereum datastore for dapp UIs.
http://truffleframework.com/docs/drizzle/getting-started
MIT License
502 stars 129 forks source link

Saga effects without a yield leads to incorrect logic #189

Closed rawfalafel closed 5 years ago

rawfalafel commented 5 years ago

Code in question is in contractsSaga.js here and here.

Should these have a yield in front? The call is always returning true, leading to bugs when the last parameter is an object.

cds-amal commented 5 years ago

Thanks for reporting this @rawfalafel! call returns an object which is truthy. Would appreciate a PR if you tackled this already.

rawfalafel commented 5 years ago

Cool! I submitted a PR, although they're missing tests.