search

trufflesuite / drizzle-legacy

Reactive Ethereum datastore for dapp UIs.
http://truffleframework.com/docs/drizzle/getting-started
MIT License
502 stars 129 forks source link

Drizzle cache does not clear error message #192

Closed rawfalafel closed 5 years ago

rawfalafel commented 5 years ago

Steps to reproduce:

  1. Call cacheCall on a contract method that reverts
  2. Wait until drizzleState contains error message in cache
  3. Update contract state so that the method doesn't revert
  4. Let cacheCall execute again. This time no revert.

Expected: cache doesn't contain contain error message Actual: cache contains error message

Here's my fix which also handles the inverse case (clearing value when a method suddenly reverts): https://github.com/UMAprotocol/drizzle/commit/4581c3dc22be88bf2b98b79599354ff63cf68bca

cds-amal commented 5 years ago

Thanks @rawfalafel! Can you submit a PR?

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

rawfalafel commented 5 years ago

Bump. I opened a PR for this issue that hasn’t been addressed. Thanks :)