search

trufflesuite / drizzle-legacy

Reactive Ethereum datastore for dapp UIs.
http://truffleframework.com/docs/drizzle/getting-started
MIT License
503 stars 128 forks source link

Better error message for invalid event name #199

Closed rahulmutt closed 5 years ago

rahulmutt commented 5 years ago

It's fairly easy to make typos when specifying events to listen to and a really large stacktrace comes up if you do.

A basic check should be done inside of addContract that ensures that the specified event names match up with the contract ABI and throws a readable exception if an invalid event is specified.

Also willing to PR this one if there's no problem.

cds-amal commented 5 years ago

Thanks @rahulmutt! Fantastic idea to validate event names. Would love to see a PR

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 5 years ago

This issue has been closed, but can be re-opened if further comments indicate that the problem persists. Feel free to tag maintainers if there is no reply to further comments.